Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all mentions of vim-json and vim-toml #602

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amarakon
Copy link
Contributor

Since vim-json and vim-toml are not needed in Vim or Neovim anymore, I removed all mentions of them in any file. It didn't allow me to push changes of .github/workflows/vader.yml.

@alerque
Copy link
Member

alerque commented Sep 28, 2022

This is looking good so far as it goes.

It didn't allow me to push changes of .github/workflows/vader.yml.

I don't understand this. You're pushing to your own fork it (GitHub) should let you push pretty much anything. It will not necessarily run the CI jobs until a maintainer approves the changes, but you shouldn't have an issue pushing to your own fork.

@amarakon
Copy link
Contributor Author

I don't understand this. You're pushing to your own fork it (GitHub) should let you push pretty much anything. It will not necessarily run the CI jobs until a maintainer approves the changes, but you shouldn't have an issue pushing to your own fork.

My bad, it was because my personal access token did not have workflow permissions. I generated a new one and added a new commit.

@alerque
Copy link
Member

alerque commented Sep 30, 2022

Great, one step closer.

Now we just need to figure out why CI isn't happy about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants