Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatible with incline.nvim #1419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

epheien
Copy link

@epheien epheien commented Jun 8, 2024

Some plugins (such as incline.nvim) need autocmd event for WinEnter, BufWinEnter, etc.

So I made some slight modifications to the code to be compatible with inline, but the modifications may not be perfect. Please carefully consider when to ignore all events and when not to ignore them

@rzvxa
Copy link
Member

rzvxa commented Jun 9, 2024

First off thanks for this amazing work.

I'm not an incline.nvim user so I wasn't aware of this issue. I'll have to test it thoroughly before merging since it might have some unexpected side effects regarding how NERDTree plugins assume the NERDTree act.

It may need to be a major version bump but I hope it can be done in the next minor release(s). I have a lot of things in my backlog in order to make NERDTree play nicely with symlinks and it demands a major release since some stuff behaves drastically differently than before so if it needs a major version bump sadly it has to wait for this annoying symlink update to get ready(which has a lot of edge cases I haven't figured out yet).

Cheers mate, VimL is ugly so I love seeing community contributions(most people don't dare to touch VimL😅).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants