Open
Conversation
Implement break and continue builtin commands to provide loop control flow: - Add Break and LoopContinue variants to ExecuteResult enum to signal loop control flow separately from normal execution and exit - Create break and continue builtin commands that return the appropriate ExecuteResult variants - Update for, while, and until loop execution to handle Break (exit loop) and LoopContinue (skip to next iteration) results - Propagate loop control flow through all command execution paths (subshells, if statements, case statements, pipelines, etc.) - Add comprehensive tests for break and continue in for loops, including nested loops All existing tests pass. The implementation follows bash semantics where: - break exits the innermost enclosing loop - continue skips to the next iteration of the innermost enclosing loop - Both commands outside of loops behave as no-ops (return 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement break and continue builtin commands to provide loop control flow:
All existing tests pass. The implementation follows bash semantics where: