enh: display directory base name as terminal title on Unix based systems (~/dir)#269
Open
kmr-srbh wants to merge 1 commit intoprefix-dev:mainfrom
Open
enh: display directory base name as terminal title on Unix based systems (~/dir)#269kmr-srbh wants to merge 1 commit intoprefix-dev:mainfrom
~/dir)#269kmr-srbh wants to merge 1 commit intoprefix-dev:mainfrom
Conversation
Author
kmr-srbh
changed the title
~/dir)~/dir)
kmr-srbh
force-pushed
the
display-unix-style-cwd
branch
from
b4b67cc to
a660418
Compare
kmr-srbh
changed the title
~/dir)~/dir)
kmr-srbh
force-pushed
the
display-unix-style-cwd
branch
from
a660418 to
143f127
Compare
wolfv
reviewed
Nov 11, 2025
| shell_options: HashMap<ShellOptions, bool>, | ||
| } | ||
|
|
||
| #[allow(clippy::print_stdout)] |
Member
There was a problem hiding this comment.
Why was this function removed? I think it seems useful and I don't see us setting the title elsewhere?
wolfv
reviewed
Nov 11, 2025
Member
There was a problem hiding this comment.
This only sets the PS1, right? Not the terminal title? Or am I missing something?
…ems (`~/dir`) Signed-off-by: Saurabh Kumar <developer.saurabh@outlook.com>
kmr-srbh
force-pushed
the
display-unix-style-cwd
branch
from
f81a79f to
e3a8414
Compare
Author
|
Hello @wolfv! Thanks for the review! :) I was developing with the VS Code integrated terminal and misunderstood the prompt string to be the terminal title. I am new to terminal emulators and learning. I have pushed the new changes. Thank you very much for your guidance! 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #237
Before
Now
Changes
cdcommand.cdcommand.