Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new adpater - Brainx #5689

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add new adpater - Brainx #5689

wants to merge 3 commits into from

Conversation

Hugh0222
Copy link

@Hugh0222 Hugh0222 commented Nov 5, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 29bfce0
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6731717d1cc39a0008fd71b3
😎 Deploy Preview https://deploy-preview-5689--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


### Registration

If you have any questions regarding set up, please reach out to your account manager or <[email protected]>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contact must be a group alias, not an individual. Our experience is that people move around a lot in ad tech.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The email address has been changed to the official email address

| Name | Scope | Description | Example | Type |
|-------------|----------|------------------------|------------------|----------|
| `pubId` | required | Placement Id | `F7B53DBC-85C1-4685-9A06-9CF4B6261FA3` | `string` |
| `endpoint` | required | Endpoint Url | `http://adx-engine-gray.tec-do.cn/bid` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config. Will place this same note on the code PRs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have made changes to the endpoint in the documentation so that it is not required.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. Noticed one more thing...

title: brainx
description: Prebid brainx Bidder Adapter
biddercode: brainx
aliasCode: fileContainingPBJSAdapterCodeIfDifferentThenBidderCode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this aliasCode line -- it will break the Download page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants