-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new adpater - Brainx #5689
base: master
Are you sure you want to change the base?
Add new adpater - Brainx #5689
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dev-docs/bidders/brainx.md
Outdated
|
||
### Registration | ||
|
||
If you have any questions regarding set up, please reach out to your account manager or <[email protected]>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contact must be a group alias, not an individual. Our experience is that people move around a lot in ad tech.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The email address has been changed to the official email address
dev-docs/bidders/brainx.md
Outdated
| Name | Scope | Description | Example | Type | | ||
|-------------|----------|------------------------|------------------|----------| | ||
| `pubId` | required | Placement Id | `F7B53DBC-85C1-4685-9A06-9CF4B6261FA3` | `string` | | ||
| `endpoint` | required | Endpoint Url | `http://adx-engine-gray.tec-do.cn/bid` | `string` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config. Will place this same note on the code PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have made changes to the endpoint in the documentation so that it is not required.
…the endpint to optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. Noticed one more thing...
title: brainx | ||
description: Prebid brainx Bidder Adapter | ||
biddercode: brainx | ||
aliasCode: fileContainingPBJSAdapterCodeIfDifferentThenBidderCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this aliasCode line -- it will break the Download page.
🏷 Type of documentation
📋 Checklist