New Adapter: Pixfuture #4117
New Adapter: Pixfuture #4117
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
|
received
…On Tue, 24 Dec 2024 at 04:56, Ashish Garg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In static/bidder-info/pixfuture.yaml
<#4117 (comment)>
:
> @@ -0,0 +1,16 @@
+endpoint: "https://srv-adapter.pixfuture.com/pixservices"
+maintainer:
+ email: ***@***.***"
Sent an email for verification. Please reply with "received".
—
Reply to this email directly, view it on GitHub
<#4117 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUDNEQT5OAVWPASNEC4GV732HEVTPAVCNFSM6AAAAABT5HIYBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRRG43DAOBRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I would like to ask for your help with reviewing a pull request [New Adapter: Pixfuture #4117]. |
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
|
Bretg, the docs PR prebid/prebid.github.io#5915 has been fixed |
|
Hello Bretg, |
|
Requesting re-review from @bsardo and @guscarreon |
|
Dear Bretg, I hope you are doing well. Best regards, |
There was a problem hiding this comment.
Since you support video, please add a new video test called video.json.
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
adapters/pixfuture/pixfuture.go
Outdated
| continue | ||
| } | ||
| bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{ | ||
| Bid: &bid, |
There was a problem hiding this comment.
Found incorrect assignment made to Bid. bid variable receives a new value in each iteration of range loop. Assigning the address of bid (&bid) to Bid will result in a pointer that always points to the same memory address with the value of the last iteration. This can lead to unexpected behavior or incorrect results. Refer https://go.dev/play/p/9ZS1f-5h4qS
Consider using an index variable in the seatBids.Bid loop as shown below
for _, seatBid := range response.SeatBid {
for i := range seatBids.Bid {
...
responseBid := &adapters.TypedBid{
Bid: &seatBids.Bid[i],
...
}
...
...
}
}
| return "", err | ||
| } | ||
|
|
||
| switch ext.Prebid.Type { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| return "", err | ||
| } | ||
|
|
||
| switch ext.Prebid.Type { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
| return "", err | ||
| } | ||
|
|
||
| switch ext.Prebid.Type { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
Co-authored-by: Sheridan C Rawlins <[email protected]>
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
|
I've addressed all the requested changes on my end. Could you please review it and let me know the next steps? |
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
|
I've addressed all the requested changes on my end. Could you please review it and let me know the next steps? |
This Pixfuture Prebid Server Adapter enables seamless integration with Pixfuture's ad exchange, allowing publishers to leverage their demand through server-side header bidding. The adapter formats outgoing bid requests, processes incoming bid responses, and adheres to OpenRTB standards for efficient and privacy-compliant ad delivery.