Sovrn: Accept imp.ext bidfloor as number or string #3955

ikagotso · 2024-10-04T10:38:56Z

purpose of this commit is to fix this issue : #3514

github-actions · 2024-10-04T10:39:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3e1298a

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:28:	MakeRequests		84.6%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:134:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:140:	MakeBids		84.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:194:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:212:	getTagId		100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:220:	getImpIdx		100.0%
github.com/prebid/prebid-server/v2/adapters/sovrn/sovrn.go:233:	Builder			100.0%
total:								(statements)		87.5%

bsardo · 2024-11-04T17:05:45Z

Hi @ikagotso, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

github-actions · 2024-11-13T11:36:09Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 55c0b16

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:29:	MakeRequests		84.6%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:135:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:141:	MakeBids		84.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:195:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:213:	getTagId		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:221:	getImpIdx		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:234:	Builder			100.0%
total:								(statements)		87.5%

ikagotso · 2024-11-13T14:04:55Z

Hi @ikagotso, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:
import (
    "github.com/prebid/prebid-server/v3/adapters"
)
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

hey,
done.

bsardo · 2024-11-21T15:48:47Z

openrtb_ext/imp_sovrn.go

-	AdUnitCode string  `json:"adunitcode,omitempty"`
+	TagId      string          `json:"tagId,omitempty"`
+	Tagid      string          `json:"tagid,omitempty"`
+	BidFloor   json.RawMessage `json:"bidfloor,omitempty"`


You can make this type interface{} and then you won't have to unmarshal in getExtBidFloor.

github-actions · 2024-11-21T18:34:03Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8069767

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:29:	MakeRequests		84.6%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:135:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:141:	MakeBids		84.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:195:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:207:	getTagId		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:215:	getImpIdx		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:228:	Builder			100.0%
total:								(statements)		87.1%

bsardo · 2024-11-22T02:46:32Z

I don't see a adapters/sovrn/params_test.go file. Please add it to ensure your bidder params rules defined in your static/bidder-params/sovrn.json file are working properly and be sure to adequately exercise these new rules for bidfloor. I suggest copying it from another adapter as a starting point.

bsardo · 2024-12-04T20:41:14Z

@ikagotso see my comment above regarding testing your bidder params.

github-actions · 2025-01-09T14:34:55Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f23949e

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:29:	MakeRequests		84.6%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:135:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:141:	MakeBids		84.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:195:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:207:	getTagId		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:215:	getImpIdx		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:228:	Builder			100.0%
total:								(statements)		87.1%

github-actions · 2025-01-14T12:18:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9b68825

sovrn

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:29:	MakeRequests		84.6%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:135:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:141:	MakeBids		84.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:195:	getExtBidFloor		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:207:	getTagId		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:215:	getImpIdx		100.0%
github.com/prebid/prebid-server/v3/adapters/sovrn/sovrn.go:228:	Builder			100.0%
total:								(statements)		87.1%

ikagotso · 2025-01-14T12:34:53Z

@ikagotso see my comment above regarding testing your bidder params.

please take a look

ikagotso added 3 commits October 1, 2024 18:34

accept both string and number

743847d

Merge branch 'refs/heads/master' into EX-5595_Bidfloor_mismatch

d08b508

Merge branch 'refs/heads/master' into EX-5595_Bidfloor_mismatch

3e1298a

przemkaczmarek self-assigned this Oct 10, 2024

przemkaczmarek previously approved these changes Oct 23, 2024

View reviewed changes

Merge branch 'refs/heads/master' into EX-5595_Bidfloor_mismatch

55c0b16

bsardo reviewed Nov 21, 2024

View reviewed changes

remove unmarshalling

8069767

ikagotso dismissed przemkaczmarek’s stale review via 8069767 November 21, 2024 18:33

bsardo previously approved these changes Nov 22, 2024

View reviewed changes

bsardo self-assigned this Nov 22, 2024

bsardo self-requested a review November 22, 2024 02:40

bsardo added the adapter label Jan 6, 2025

ikagotso added 3 commits January 8, 2025 17:44

Merge branch 'refs/heads/master' into EX-5595_Bidfloor_mismatch

1a8ee86

add params_test.go

bca9d8c

Merge branch 'refs/heads/master' into EX-5595_Bidfloor_mismatch

55327ab

ikagotso dismissed bsardo’s stale review via 55327ab January 9, 2025 14:06

ikagotso added 2 commits January 9, 2025 18:31

fix

4bf4886

fix

f23949e

Merge branch 'refs/heads/master' into EX-5595_Bidfloor_mismatch

9b68825

bsardo approved these changes Jan 16, 2025

View reviewed changes

bsardo changed the title ~~Sovrn: Accept Imp.ext Bidfloor either as a number or string~~ Sovrn: Accept imp.ext bidfloor as number or string Jan 16, 2025

przemkaczmarek approved these changes Jan 16, 2025

View reviewed changes

bsardo merged commit ac66d8c into prebid:master Jan 18, 2025
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Jan 18, 2025

Port PR from PBS-Go: Sovrn: Accept imp.ext bidfloor as number or string prebid/prebid-server-java#3686

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sovrn: Accept imp.ext bidfloor as number or string #3955

Sovrn: Accept imp.ext bidfloor as number or string #3955

ikagotso commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 13, 2024

ikagotso commented Nov 13, 2024

bsardo Nov 21, 2024

github-actions bot commented Nov 21, 2024

bsardo commented Nov 22, 2024

bsardo commented Dec 4, 2024

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 14, 2025

ikagotso commented Jan 14, 2025

Sovrn: Accept imp.ext bidfloor as number or string #3955

Sovrn: Accept imp.ext bidfloor as number or string #3955

Conversation

ikagotso commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

Code coverage summary

sovrn

bsardo commented Nov 4, 2024

github-actions bot commented Nov 13, 2024

Code coverage summary

sovrn

ikagotso commented Nov 13, 2024

bsardo Nov 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

Code coverage summary

sovrn

bsardo commented Nov 22, 2024

bsardo commented Dec 4, 2024

github-actions bot commented Jan 9, 2025

Code coverage summary

sovrn

github-actions bot commented Jan 14, 2025

Code coverage summary

sovrn

ikagotso commented Jan 14, 2025