Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major(core): remove replaceNode functionality #4359

Open
wants to merge 3 commits into
base: breaking-changes
Choose a base branch
from
Open

major(core): remove replaceNode functionality #4359

wants to merge 3 commits into from
+14 −263

Conversation

JoviDeCroock
Copy link
Member

This removes the replaceNode functionality, you can still polyfill the functionality like this

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +0% (-3.58ms - +0.15ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.01ms - +0.23ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-2.50ms - +1.27ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +4% (-0.58ms - +0.64ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.79ms - +1.86ms)
    preact-local vs preact-main
  • text-update: slower ❌ 2% - 6% (0.04ms - 0.13ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -5% - +1% (-1.24ms - +0.31ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +3% (-0.80ms - +1.09ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +0% (-0.41ms - +0.04ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local859.68ms - 862.08ms-unsure 🔍
-0% - +0%
-3.58ms - +0.15ms
preact-main861.17ms - 864.02msunsure 🔍
-0% - +0%
-0.15ms - +3.58ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.15ms - 25.15ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main25.15ms - 25.15msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.69ms - 16.91ms-unsure 🔍
-0% - +1%
-0.01ms - +0.23ms
preact-main16.64ms - 16.73msunsure 🔍
-1% - +0%
-0.23ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.69ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.69ms - 1.70msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.53ms - 77.00ms-unsure 🔍
-3% - +2%
-2.50ms - +1.27ms
preact-main74.96ms - 77.80msunsure 🔍
-2% - +3%
-1.27ms - +2.50ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local13.12ms - 13.31ms-unsure 🔍
-3% - +0%
-0.41ms - +0.04ms
preact-main13.20ms - 13.61msunsure 🔍
-0% - +3%
-0.04ms - +0.41ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.24ms - 17.88ms-unsure 🔍
-3% - +4%
-0.58ms - +0.64ms
preact-main17.01ms - 18.05msunsure 🔍
-4% - +3%
-0.64ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.62ms - 4.62ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.61ms - 4.62msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local81.50ms - 84.00ms-unsure 🔍
-2% - +2%
-1.79ms - +1.86ms
preact-main81.39ms - 84.04msunsure 🔍
-2% - +2%
-1.86ms - +1.79ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.56ms - 3.59ms-unsure 🔍
-1% - +0%
-0.02ms - +0.02ms
preact-main3.56ms - 3.59msunsure 🔍
-0% - +1%
-0.02ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.14ms - 30.98ms-unsure 🔍
-1% - +3%
-0.35ms - +0.76ms
preact-main29.99ms - 30.71msunsure 🔍
-2% - +1%
-0.76ms - +0.35ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local36.19ms - 38.07ms-unsure 🔍
-3% - +4%
-1.24ms - +1.58ms
preact-main35.91ms - 38.01msunsure 🔍
-4% - +3%
-1.58ms - +1.24ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local27.08ms - 27.58ms-unsure 🔍
-3% - +1%
-0.79ms - +0.22ms
preact-main27.17ms - 28.05msunsure 🔍
-1% - +3%
-0.22ms - +0.79ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local33.42ms - 35.03ms-unsure 🔍
-3% - +4%
-1.15ms - +1.39ms
preact-main33.12ms - 35.09msunsure 🔍
-4% - +3%
-1.39ms - +1.15ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.80ms - 24.69ms-unsure 🔍
-5% - +5%
-1.11ms - +1.28ms
preact-main22.93ms - 24.39msunsure 🔍
-5% - +5%
-1.28ms - +1.11ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local24.83ms - 25.90ms-unsure 🔍
-4% - +2%
-1.16ms - +0.45ms
preact-main25.12ms - 26.32msunsure 🔍
-2% - +5%
-0.45ms - +1.16ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.08ms - 2.14ms-slower ❌
2% - 6%
0.04ms - 0.13ms
preact-main2.00ms - 2.06msfaster ✔
2% - 6%
0.04ms - 0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main0.98ms - 0.98msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local26.06ms - 26.45ms-unsure 🔍
-5% - +1%
-1.24ms - +0.31ms
preact-main25.97ms - 27.48msunsure 🔍
-1% - +5%
-0.31ms - +1.24ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.70ms - 33.37ms-unsure 🔍
-2% - +3%
-0.80ms - +1.09ms
preact-main31.96ms - 32.83msunsure 🔍
-3% - +2%
-1.09ms - +0.80ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.55ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.55ms - 3.55msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Size Change: -136 B (-0.22%)

Total Size: 61.9 kB

Filename Size Change
dist/preact.js 4.69 kB -22 B (-0.47%)
dist/preact.min.js 4.72 kB -23 B (-0.48%)
dist/preact.min.module.js 4.72 kB -23 B (-0.48%)
dist/preact.min.umd.js 4.75 kB -22 B (-0.46%)
dist/preact.module.js 4.71 kB -24 B (-0.51%)
dist/preact.umd.js 4.77 kB -22 B (-0.46%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.1 kB
compat/dist/compat.module.js 4.03 kB
compat/dist/compat.umd.js 4.17 kB
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 273 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited
Loading

Coverage Status

coverage: 99.486%. remained the same
when pulling e864f10 on remove-replace-node
into a1c6988 on breaking-changes.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:11
@JoviDeCroock JoviDeCroock reopened this Jul 23, 2024
@JoviDeCroock JoviDeCroock changed the base branch from breaking-changes-11 to breaking-changes July 23, 2024 19:28
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoviDeCroock @coveralls