Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dictation to be remapped with Simple Modifications #3913

Closed
wants to merge 1 commit into from

Conversation

djsavvy
Copy link

@djsavvy djsavvy commented Aug 28, 2024

Perhaps I'm being Chesterton's Fence'd here, but I don't see why the dictation button can't be remapped with simple_modifications. I just compiled it and tried it on my local machine, and it seems to work well.

EDIT: I think this would also provide much easier/more effective workarounds for #2516 and #3123. I stumbled on this behavior because I tried to remap dictation (which is what pressing f5 on an external keyboard shows as) via the simple_modifications UI.

@tekezo
Copy link
Member

tekezo commented Aug 29, 2024

@djsavvy Thank you! I have one clarification.

The function keys on MacBook or Apple keyboard, as well as the F5 key on external keyboards, actually correspond to { "key_code": "f5" }, not dictation. Therefore, trying to remap the dictation key usually has no effect, which is why it's excluded from the from target key. (To achieve the desired behavior, we need to change Functions keys > f5.)

If you have an external keyboard that truly sends the dictation key code, then we shouldn remove not_from, but do you have such a keyboard?

Specifically, for example, when you configure the settings as shown in the image below, does the dictation key function as mute?

Screenshot 2024-08-30 at 8 19 37

@djsavvy
Copy link
Author

djsavvy commented Sep 4, 2024

Heyt @tekezo thanks for the response. I tried it, and you're right that the keycode being sent is actually f5 and not dictation. I thought that dictation was the correct key code because that's what the Karabiner event viewer shows.

In order for my external keyboard to actually send f5 on f5, I needed to map f5 to f5. Looks dumb, but it works!

I guess there's no need for this PR then — thanks for reviewing and clarifying.

@djsavvy djsavvy closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants