Delete copy constructor of core_configuration::details::delete

pqrs-org · Jun 11, 2024 · 22f05ff · 22f05ff
1 parent 0dc5af9
commit 22f05ff
Show file tree

Hide file tree

Showing 7 changed files with 256 additions and 248 deletions.
diff --git a/src/share/core_configuration/configuration_json_helper.hpp b/src/share/core_configuration/configuration_json_helper.hpp
@@ -100,9 +100,17 @@ class array_t final : public base_t {
   }
 
   void update_value(const nlohmann::json& json) override {
-    if (auto v = pqrs::json::find_array(json, key_)) {
-      for (const auto& j : v->value()) {
+    if (!json.contains(key_)) {
+      return;
+    }
+
+    pqrs::json::requires_array(json[key_], "`" + key_ + "`");
+
+    for (const auto& j : json[key_]) {
+      try {
         value_.push_back(std::make_unique<T>(j));
+      } catch (const pqrs::json::unmarshal_error& e) {
+        throw pqrs::json::unmarshal_error(fmt::format("`{0}` entry error: {1}", key_, e.what()));
       }
     }
   }