Fix ARIA Live Region screen reader issue in Firefox #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @geo-connor will check this out on Monday |
|
Sorry haven't gotten around to it yet. |
|
Have you tested this with VoiceOver as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch removes the
aria-relevant="additions"attribute from the screen reader assistant element. This attribute currently prevents assistant text from being announced by screen readers in Firefox (tested using NVDA).It's my understanding that there are few advantage to setting
aria-relevantunless you want to encourage screen readers to announce more changes (using"all"to announce content removals). The default value ofaria-relevantis"additions text". Is it necessary to exclude text changes from being announced here?resolves #403