Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default multiplier for mania key mods #30506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Nov 5, 2024

Resolves #30503

This doesn't go the full way. osu!stable will decrease the multiplier further if new_keys < old_keys, but this is hard to do here due to lack of ordering of calls to IApplicableToDifficulty.

legacy: 859241
before: 959013
after: 863112

Those scoring values have been computed locally. Note that the "before" variant differs from the website because of a bug with not including mods correctly, that seems to have since been resolved but attributes haven't been reprocessed yet (#29772).

@bdach
Copy link
Collaborator

bdach commented Nov 5, 2024

First of all:

!diffcalc
RULESET=mania
GENERATORS=score

Secondly: does this impact lazer scores at all? Because if it does, then a reverify is not enough. We'd need something like ppy/osu-queue-score-statistics#269.

@smoogipoo
Copy link
Contributor Author

does this impact lazer scores at all?

Yes actually. That somehow totally slipped my mind.

Copy link

github-actions bot commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scores using 4 key mod on 5 maps can have more than 1m score
2 participants