Add default multiplier for mania key mods #30506
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #30503
This doesn't go the full way. osu!stable will decrease the multiplier further if
new_keys < old_keys
, but this is hard to do here due to lack of ordering of calls toIApplicableToDifficulty
.Those scoring values have been computed locally. Note that the "before" variant differs from the website because of a bug with not including mods correctly, that seems to have since been resolved but attributes haven't been reprocessed yet (#29772).