Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sprite.rect property, a 4-tuple controlling whthe src-rect to… #475

Open
wants to merge 1 commit into
base: canon
Choose a base branch
from

Conversation

ironfroggy
Copy link
Contributor

@ironfroggy ironfroggy commented May 17, 2020

… render from the texture.

This allows rendering from a spritesheet by specifying a rectangle on the sheet from which to render.

@ironfroggy ironfroggy requested a review from a team as a code owner May 17, 2020 21:17
@ironfroggy
Copy link
Contributor Author

If this or a version of this is merged, I'd also like to contribute a ppb.features.spritesheet to make use of it with traditional spritesheets easier. Automatic slicing, that sort of thing.

@pathunstrom
Copy link
Collaborator

I like the idea of this, but I think we need to figure out some of the stuff around this API, so going to say let's have the conversation, and we'll make figuring this out a priority for the 0.10 work. (Not going to close it though, because this might be pretty close to the renderer implementation no matter how the rest of the discussion goes.)

@pathunstrom pathunstrom changed the base branch from master to canon June 27, 2020 11:02
@pathunstrom
Copy link
Collaborator

Going to connect this to #501 and the discussion around the future of assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants