Update test matrix to include 2.18, 3.4, 3.8, and 3.12 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobq
changed the title
|
hmm these failures on Travis seem like they could be due to the old Node version…? |
jacobq
force-pushed
the
fix-unload-race
branch
from
1b4e97c
to
00334ae
Compare
Oops, yes, that's due to the previous upgrade to PouchDB 7.1.1 (not me). That was a breaking change. I forced pushed and noted this. |
BREAKING CHANGE: drop support for node 6.x Actually, the upgrade to PouchDB 7.1.1 forces this (see commit 28c5739)
The test labeled "creating an associated record stores a reference to it in the parent" was failing intermittently with the recently added ember LTS versions (e.g. 3.4) when run with other tests under conditions "dont save hasMany" and "sync". This problem appears to be caused by the test logic not waiting for `store.unloadAll()` to complete. The Ember Data API docs state that this function schedules its work to be done during the next run loop, so this commit wraps these calls with `Ember.run` to ensure that it finishes before continuing. See also: * https://api.emberjs.com/ember-data/3.14/classes/Store/methods/unloadAll?anchor=unloadAll * pouchdb-community#242 * pouchdb-community#243
jacobq
force-pushed
the
fix-unload-race
branch
from
00334ae
to
1aa5ca3
Compare
|
I'm guessing that the subsequent failure has to do with the outdated |
|
Excellent, thanks for the followthrough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #246
Broadens test support matrix (Closes #242) and fixes test suite race condition with
store.unloadAllthat starts appearing in these newer versions (Closes #243).