Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 support, explicit IPs #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mfschumann
Copy link

I have added support for IPv6 addresses and for specifying IPs explicitely. In the process, I have switched from ipinfo.io to ipify.org because they offer both IPv4 and IPv6 support.

- switched to ipify.org for IP detection
- added support for explicit IP specification
@mfschumann mfschumann mentioned this pull request Jun 22, 2019
Copy link

@dudu15051505 dudu15051505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script works perfectly as expected with the update of IPV6!
I only recommend that a change to the README be made for both ipv4 and v6 to inform that when using the -UseDns parameter, the script will use the local dns of the PC to check the current ip in the dns register and may cause a false positive response when configured the dns proxy in CloudFlare, without the parameter the script directly queries the record in CloudFlare and does not cause false positive problems.

@mfschumann
Copy link
Author

Thanks @dudu15051505.
Regarding your suggestion, I don't really see how this relates to the changes I made. Would you mind to open a separate pull request or issue?

@dudu15051505
Copy link

@mfschumann a new pull request is better for this suggestion, but is not the extremely important, is just a note to informe of the use in the parrameter -UseDns and the http proxy on cloudflare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants