Make type declarations more accurate #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that `ChildProps` requires at least one of concrete
property which indicates what type of node should be created.
Also updates `Container.normalize()` to create a `Rule()` when passed
`{selectors: ...}`.
Roots are always handled by `Container.normalize()`, which flattens them out into their constituent children.
ai
reviewed
Jul 27, 2024
ai
reviewed
Jul 28, 2024
lib/at-rule.d.ts
Outdated
| clone(overrides?: Partial<AtRule.AtRuleProps>): AtRule | ||
| cloneAfter(overrides?: Partial<AtRule.AtRuleProps>): AtRule | ||
| cloneBefore(overrides?: Partial<AtRule.AtRuleProps>): AtRule | ||
| clone(overrides?: Partial<AtRule.AtRuleProps>): this |
There was a problem hiding this comment.
Why it is this if we clone, create a new object?
There was a problem hiding this comment.
this doesn't mean the current object, it just means the type of the current class. This means that a subtype will automatically treat this as returning its own type, rather than returning the superclass AtRule. See this documentation.
ai
reviewed
Jul 28, 2024
ai
reviewed
Jul 28, 2024
|
Merged main and added a declaration for |
ai
reviewed
Aug 2, 2024
|
Released in 8.4.41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also helps make it feasible to extend these types for
sass/dart-sass#88.