-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jupyter intergration testing to CI #350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
approved these changes
Feb 9, 2023
tdstein
reviewed
Feb 9, 2023
tdstein
reviewed
Feb 9, 2023
tdstein
reviewed
Feb 9, 2023
tdstein
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All of my comments are minor questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rsconnect-jupyter
usesrsconnect-python
to add servers and deploy content. Due to this dependency, we've had to manually testrsconnect-jupyter
for allrsconnect-python
releases. This can cause delays in the release process or defects inrsconnect-jupyter
if not properly tested. Adding tests in CI protects us from making breaking changes torsconnect-jupyter
. This will also set us up to test for voila mode inrsconnect-jupyter
.Motivation and Context
We've had to hold releases or release patches in the past to fix breaking changes in
rsconnect-jupyter
.How Has This Been Tested?
The tests are currently passing:
https://github.com/rstudio/rsconnect-python/actions/runs/4135755212
Cypress failures cause CI to fail:
https://github.com/rstudio/rsconnect-python/actions/runs/4135608575
In the
intergration-testing
directory, run:just build && just up && just up-cypress
just build
build the docker images (client
,cypress
)just up
will start the docker images (client
,connect
)just up-cypress
will start thecypress
docker image and run the tests.The
client
container is wherersconnect-python
andrsconnect-jupyter
packages are installed.rsconnect-jupyter
installs on thejust build
command where the current dev build ofrsonnect-python
gets installed on thejust up
command so rebuilding isn't necessary to get the currentrsconnect-python
dev build.The
connect
container is pulled from docker hub with the latest version of Posit Connect.The
cypress
container runs cypress version 12.0.0 and tests all defined specs on thejust up-cypress
command.Fixes #351
Screenshots (if appropriate):
Types of Changes
Checklist: