Add snowflake support to connections pane #9219
Open
+297
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalbel
force-pushed
the
connections/snowflake
branch
from
8e24bb1 to
577cedc
Compare
isabelizimm
previously approved these changes
Sep 8, 2025
| query = f'SELECT * FROM "{database.name}"."{schema.name}"."{table.name}" LIMIT 1000;' | ||
| var_name = var_name or "conn" | ||
| preview = self.conn.cursor().execute(query).fetch_pandas_all() | ||
| sql = ( |
There was a problem hiding this comment.
thanks for adding this in! 🙌
|
|
||
| database, schema, table = path | ||
|
|
||
| # Use DuckDB's native pandas integration via .df() method |
There was a problem hiding this comment.
should this be snowflake? or does this use the builtin duckdb?
There was a problem hiding this comment.
oops! I copied the duckdb implements as a template and forgot to remove
| # Use DuckDB's native pandas integration via .df() method | ||
| query = f'SELECT * FROM "{database.name}"."{schema.name}"."{table.name}" LIMIT 1000;' | ||
| var_name = var_name or "conn" | ||
| preview = self.conn.cursor().execute(query).fetch_pandas_all() |
There was a problem hiding this comment.
and it doesn't look like pandas is a required dependency, should we try/except to make sure it is available?
There was a problem hiding this comment.
if pandas is not installed, this will error with a reasonably error message surfaced to the user through a notification in Positron.
This is hopefully enough to get users to install pandas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8580
TODO:
Release Notes
New Features
Bug Fixes
QA Notes
Request a Snowflake Developer account with IT, then use: