Skip to content

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Aug 28, 2025

Main goal here is to correctly size cell code editors, so things like breakpoints are accessible. Also removed some parts that didn't seem to be doing anything - hopefully nothing breaks! Addresses #9245.

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@seeM seeM requested review from nstrayer and austin3dickey August 28, 2025 18:16
Copy link
Contributor

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!


// disposables.add(editor.onDidBlurEditorWidget(() => {
// }));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unused comment

Copy link
Contributor

@nstrayer nstrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have my laptop to run the code but looking at it it looks great. This was an area i handwaved my way through initially so I'm glad the tech debt is being paid off!

@seeM seeM merged commit bca395e into main Sep 1, 2025
9 checks passed
@seeM seeM deleted the bugfix/editor-layout branch September 1, 2025 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants