Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot editor tab sizing policies #6043

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

timtmok
Copy link
Contributor

@timtmok timtmok commented Jan 17, 2025

Release Notes

Addresses #5522 and #4358

Each plot client has their own metadata that now includes the sizing policy. Each plot can, whether it is in an editor tab or the view, independently set a sizing policy that will be restored on reload.

Adds an action that can switch between sizing policies for the selected plot. The action only shows the options that would be available from the sizing policy menu button in the Plots view. A custom sizing policy can only be set if there already is one set in the Plots view. It cannot be altered from the action.

Restored editors might not restore to the same editor group if there are multiple. I can follow up with adding that to the plot metadata so it can be restored to the same location. The editor order may also not be the same but I think we can live with that.

Finally, it also needs another update later to add the action to the editor toolbar but that will need more work to allow a menu style button.

Screen.Recording.2025-01-17.at.4.27.23.PM.mov

New Features

  • Plots in editor tabs are restored when the window is reloaded.
  • Plots in editor tabs can change their sizing policy independently of the Plots view. This is invoked via the Command Palette under Change Plot Sizing Policy

Bug Fixes

  • N/A

QA Notes

This is still hidden behind an experimental setting.

@timtmok timtmok requested a review from jmcphers January 17, 2025 21:30
Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant