Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue preventing drag-and-drop files into Explorer view #6030

Merged
merged 2 commits into from
Jan 18, 2025
+14 −0
Merged

Fix issue preventing drag-and-drop files into Explorer view #6030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8872ae1
always "allow" file uploads/downloads in desktop mode
jmcphers Jan 17, 2025
548d3e2
Merge remote-tracking branch 'origin/main' into bugfix/file-drag-n-drop
jmcphers Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/vs/workbench/services/environment/electron-sandbox/environmentService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,20 @@ export class NativeWorkbenchEnvironmentService extends AbstractNativeEnvironment
@memoize
get filesToWait(): IPathsToWaitFor | undefined { return this.configuration.filesToWait; }

// --- Start Positron ---
// Always file downloads and uploads on Positron Desktop. These can be
// disabled in browser mode for security reasons (see
// BrowserWorkbenchEnvironmentService), but are always enabled in the
// desktop/Electron configuration.
get isEnabledFileDownloads(): boolean {
return true;
}

get isEnabledFileUploads(): boolean {
return true;
}
// --- End Positron ---

constructor(
private readonly configuration: INativeWindowConfiguration,
productService: IProductService
Expand Down
Loading