Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address 5736 by adding new submenu handling #5837

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Address 5736 by adding new submenu handling #5837

wants to merge 1 commit into from
+46 −20

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Dec 19, 2024 •
edited
Loading

Description

This PR addresses #5736 by adding new submenu handling.

Before this PR:

image

After this PR:

image

Note how the Editor Action Bar now mirrors the Editor Actions, as expected.

image

QA Notes

None.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

juliasilge
juliasilge approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great 🙌 and the Jupyter notebook extension's use of editor actions is a good example for how to set up a button with a dropdown menu.

@midleman
Copy link
Contributor

midleman commented Dec 20, 2024 •
edited
Loading

Nice! Just to verify the tests are still good after this change... In this order, could you:

  1. add this anywhere in your PR description: @:editor-action-bar (it will run the editor-action-bar e2e test on the next change you push up or on re-run)
  2. update your branch with latest code (in order to pick up new test changes from this morning) and kick off the tests again with editor-action-bar included

More about running certain test tags on PRs can be read about here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasilge juliasilge juliasilge approved these changes

@isabelizimm isabelizimm Awaiting requested review from isabelizimm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@softwarenerd @midleman @juliasilge