Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output channel names consistent #5833

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Make output channel names consistent #5833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20421b6
Remove positron prefix from output channel names
dhruvisompura Dec 19, 2024
58d3854
Rename language pack output channels
dhruvisompura Dec 19, 2024
1e14d33
Update LSP output channel name format
dhruvisompura Dec 19, 2024
84cab0c
Format file
dhruvisompura Dec 19, 2024
4814b9a
Add overlay to channel name change
dhruvisompura Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/positron-code-cells/src/logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as vscode from 'vscode';

let channel: vscode.OutputChannel | undefined;
export function initializeLogging() {
channel = vscode.window.createOutputChannel('Positron Code Cells');
channel = vscode.window.createOutputChannel('Code Cells');
}

export function trace(message: string) {
Expand Down
2 changes: 1 addition & 1 deletion extensions/positron-notebook-controllers/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { JUPYTER_NOTEBOOK_TYPE } from './constants';
import { registerExecutionInfoStatusBar } from './statusBar';
import { getNotebookSession, isActiveNotebookEditorUri } from './utils';

export const log = vscode.window.createOutputChannel('Positron Notebook Controllers', { log: true });
export const log = vscode.window.createOutputChannel('Notebook Controllers', { log: true });

const _onDidSetHasRunningNotebookSessionContext = new vscode.EventEmitter<boolean>();

Expand Down
2 changes: 1 addition & 1 deletion extensions/positron-proxy/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type ProxyServerStyles = { readonly [key: string]: string | number };
/**
* Positron Proxy log output channel.
*/
export const log = vscode.window.createOutputChannel('Positron Proxy', { log: true });
export const log = vscode.window.createOutputChannel('HTML Proxy Server', { log: true });

/**
* Activates the extension.
Expand Down
4 changes: 3 additions & 1 deletion extensions/positron-python/src/client/common/utils/localize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ export namespace InterpreterQuickPickList {

export namespace OutputChannelNames {
export const languageServer = l10n.t('Python Language Server');
export const python = l10n.t('Python');
// --- Start Positron ---
export const python = l10n.t('Python Language Pack');
dhruvisompura marked this conversation as resolved.
Show resolved Hide resolved
// --- End Positron ---
export const pythonTest = l10n.t('Python Test Log');
}

Expand Down
6 changes: 4 additions & 2 deletions extensions/positron-python/src/client/positron/lspOutputChannelManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import * as vscode from 'vscode';

const LSP_OUTPUT_CHANNEL_PREFIX = 'Positron Language Server: ';
const LSP_OUTPUT_CHANNEL_DESCRIPTOR = 'Language Server';

/**
* Manages all the Python LSP output channels
Expand Down Expand Up @@ -47,7 +47,9 @@ export class PythonLspOutputChannelManager {
let out = this._channels.get(key);

if (!out) {
const name = `${LSP_OUTPUT_CHANNEL_PREFIX}${sessionName} (${sessionMode})`;
const name = `${sessionName}: ${LSP_OUTPUT_CHANNEL_DESCRIPTOR} (${
sessionMode.charAt(0).toUpperCase() + sessionMode.slice(1)
})`;
out = vscode.window.createOutputChannel(name);
this._channels.set(key, out);
}
Expand Down
2 changes: 1 addition & 1 deletion extensions/positron-r/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { setupTestExplorer, refreshTestExplorer } from './testing/testing';
import { RRuntimeManager } from './runtime-manager';
import { registerUriHandler } from './uri-handler';

export const LOGGER = vscode.window.createOutputChannel('Positron R Extension', { log: true });
export const LOGGER = vscode.window.createOutputChannel('R Language Pack', { log: true });

export function activate(context: vscode.ExtensionContext) {
const onDidChangeLogLevel = (logLevel: vscode.LogLevel) => {
Expand Down
4 changes: 2 additions & 2 deletions extensions/positron-r/src/lsp-output-channel-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import * as vscode from 'vscode';

const LSP_OUTPUT_CHANNEL_PREFIX = 'Positron Language Server: ';
const LSP_OUTPUT_CHANNEL_DESCRIPTOR = 'Language Server';

/**
* Manages all the R LSP output channels
Expand Down Expand Up @@ -47,7 +47,7 @@ export class RLspOutputChannelManager {
let out = this._channels.get(key);

if (!out) {
const name = `${LSP_OUTPUT_CHANNEL_PREFIX}${sessionName} (${sessionMode})`;
const name = `${sessionName}: ${LSP_OUTPUT_CHANNEL_DESCRIPTOR} (${sessionMode.charAt(0).toUpperCase() + sessionMode.slice(1)})`;
out = vscode.window.createOutputChannel(name);
this._channels.set(key, out);
}
Expand Down
2 changes: 1 addition & 1 deletion extensions/positron-run-app/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { PositronRunAppApiImpl } from './api';
import { registerDebugAdapterTrackerFactory } from './debugAdapterTrackerFactory';
import { PositronRunApp } from './positron-run-app';

export const log = vscode.window.createOutputChannel('Positron Run App', { log: true });
export const log = vscode.window.createOutputChannel('App Launcher', { log: true });

export enum Config {
ShellIntegrationEnabled = 'terminal.integrated.shellIntegration.enabled',
Expand Down
2 changes: 1 addition & 1 deletion extensions/positron-supervisor/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { KCApi } from './KallichoreAdapterApi';
export let API_INSTANCE: KCApi;

export function activate(context: vscode.ExtensionContext): KallichoreAdapterApi {
const log = positron.window.createRawLogOutputChannel('Positron Kernel Supervisor');
const log = positron.window.createRawLogOutputChannel('Kernel Supervisor');
log.appendLine('Positron Kernel Supervisor activated');

// Create the singleton instance of the Kallichore API wrapper
Expand Down
Loading