Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the supervisor can start even when http_proxy is set #5825

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jmcphers
Copy link
Collaborator

We have had several user reports of the kernel supervisor failing to start because of HTTP proxy settings (specifically via the http_proxy environment variable). This happens because the Node request library we use reads the http_proxy environment variable and always attempts to use the proxy (even, surprisingly enough, for local connections).

The fix here is -- when http_proxy is set -- to amend the no_proxy environment variable so that the proxy is not used when connecting to the supervisor.

Partially addresses #5481.

QA Notes

It can be a little tricky to set environment variables for Positron. The easiest way is probably to set them in a terminal and then launch Positron from that terminal.

Copy link

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

@jmcphers jmcphers requested a review from juliasilge December 19, 2024 00:04
Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a local release build from this PR and set http_proxy to a nonsense URL.

  • With a recent release build, runtimes cannot start and I see the error "Invalid URL".
  • With the local release build from this PR, all my runtimes start up with no problem. ✅

@jmcphers jmcphers merged commit dbcb3b6 into main Dec 19, 2024
6 checks passed
@jmcphers jmcphers deleted the bugfix/supervisor-http-proxy branch December 19, 2024 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants