Ensure the supervisor can start even when http_proxy
is set
#5825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had several user reports of the kernel supervisor failing to start because of HTTP proxy settings (specifically via the
http_proxy
environment variable). This happens because the Node request library we use reads thehttp_proxy
environment variable and always attempts to use the proxy (even, surprisingly enough, for local connections).The fix here is -- when
http_proxy
is set -- to amend theno_proxy
environment variable so that the proxy is not used when connecting to the supervisor.Partially addresses #5481.
QA Notes
It can be a little tricky to set environment variables for Positron. The easiest way is probably to set them in a terminal and then launch Positron from that terminal.