e2e tests: use webbrowser to check for urls in viewer #5818
+7
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
|
|
just add this anywhere in your PR description. backticks are not required... |
|
Updated, looks like they're running now(?). That is so slick! |
Almost. If you added the tag after your test job kicked off, it wouldn't have picked them up. But if you pushed up any new changes or re-run them since the addition, the tests tagged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #5569
@:viewer
I don't think that the idea of printing the url after the API is started is super feasible on the vetiver side (see rstudio/vetiver-python#219). I have an alternative test instead where we open up an arbitrary blank webpage. AFAICT the main purpose of this test is to make sure the viewer is intercepting
webbrowsercalls and opening them in the Viewer pane, so this will still check for all those tasks. LMK if this seems like a reasonable option!Can also probably pull vetiver as a dependency, as webbrowser is a builtin Python module (which is a second bonus, since vetiver has a few large dependencies 😆)
QA Notes
should pass CI