Fix reconnection errors in some multi-window workflows #5817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5750.
The underlying issue is somewhat complicated. Basically:
The fix is to manually clear out the sessions from ephemeral storage on close/quit.
This is not related to the 1.95 merge.
QA Notes
This does not reproduce reliably with the steps in #5750. Here are steps that will cause it to reproduce every time in builds prior to this change.
In Step 5, you will see the window attempt to connect to the sessions that you started in Step 3, but get HTTP 404 since those sessions are not running any more.
Also note that the purpose of this machinery is to reconnect to sessions on reload/re-navigate, so double check that that still works.