disable extension validation in Positron #5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
petetronic
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes Positron to skip extension validation. Extension validation isn't a new feature from upstream, but it is a feature that was formerly not very aggressive. In this change from upstream 1.94 (which we picked up with the 1.93 -> 1.95 upstream merge), VS Code started blocking installation when signature verification fails.
microsoft/vscode@2991008
This change also added a new option,
extensions.verifySignature, which controls the new behavior. The fix is to effectively hide this option and never perform signature verification.In early drafts of this change I considered just defaulting the setting to
false, but it turns out that Positron is missing an essential binary needed to perform signature verification (@vscode/vsce-sign), so we cannot verify signatures. Verification is also restricted to Windows and macOS platforms, even in upstream VS Code.This fix is a stopgap to get installation back online quickly. In the long term, we should consider investigating what work is needed to perform signature verification. While Positron does not bundle a copy of the vsce-sign tool, the tool is distributed on npm (note however that it is closed source and under a Microsoft license). https://www.npmjs.com/package/@vscode/vsce-sign
Addresses #5758.
QA Notes
Installing from local VSIX files as well as OpenVSX should work smoothly.