API for extending the connections pane #5785
Merged
+466
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
jmcphers
previously approved these changes
Dec 19, 2024
src/positron-dts/positron.d.ts
Outdated
| @@ -1101,6 +1101,53 @@ declare module 'positron' { | |||
| pasteText(text: string): void; | |||
| } | |||
|
|
|||
| export interface ConnectionsInput { | |||
| // The unique identifier for the input. | |||
There was a problem hiding this comment.
These comments on interface members should use either the /// form or the /** form so that they show up in intellisense (etc).
| if (!driver || !driver.checkDependencies) { | ||
| throw new Error(`Driver ${driverId} does not support checking dependencies`); | ||
| } | ||
| return await driver.checkDependencies(); |
There was a problem hiding this comment.
Nit: here and elsewhere, the await is unnecessary here -- the async syntax sugar will chain the promise for you if you return it directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #5689
Add a positron public API that can be used to register new connection drivers. Registered drivers are used by the connections pane 'New Connection' button.