Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/ci: adjust CI testing for python 3.8 #5782

Merged
merged 8 commits into from
Dec 20, 2024
Merged

python/ci: adjust CI testing for python 3.8 #5782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6797f7
adjust for python 3.8 and 3.13
isabelizimm Dec 17, 2024
66c7764
do not use 3.13 dev
isabelizimm Dec 17, 2024
976c712
use pandas 2.2.3
isabelizimm Dec 17, 2024
cc76f20
update torch, sqlalchemy
isabelizimm Dec 17, 2024
fefb131
pyright ignore for unknown members
isabelizimm Dec 17, 2024
028a992
newer pyarrow as well
isabelizimm Dec 17, 2024
cae36fe
just update 3.8 for now
isabelizimm Dec 19, 2024
53907ce
back down on versions since no 3.13
isabelizimm Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/positron-python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ jobs:
strategy:
matrix:
include:
- os: 'ubuntu-latest'
python: '3.8'
- os: 'macos-latest'
python: '3.9'
- os: 'windows-latest'
Expand All @@ -159,6 +157,9 @@ jobs:
python: '3.11'
- os: 'ubuntu-latest'
python: '3.12'
# add in 3.13 when ibis-framework[duckdb] supports it
# - os: 'ubuntu-latest'
# python: '3.13'

steps:
- name: Checkout
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/positron-python-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ jobs:
python: '3.11'
- os: 'ubuntu-latest'
python: '3.12'
# add in 3.13 when ibis-framework[duckdb] supports it
# - os: 'ubuntu-latest'
# python: '3.13'


steps:
- name: Checkout
Expand Down Expand Up @@ -94,6 +98,10 @@ jobs:
python: '3.11'
- os: 'ubuntu-latest'
python: '3.12'
# add in 3.13 when ibis-framework[duckdb] supports it
# - os: 'ubuntu-latest'
# python: '3.13'


steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion extensions/positron-python/python_files/positron/positron_ipykernel/inspectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ def get_display_value(
"edgeitems": ARRAY_EDGEITEMS,
"linewidth": print_width,
}
options_obj = torch._tensor_str.PRINT_OPTS
options_obj = torch._tensor_str.PRINT_OPTS # type: ignore[reportGeneralTypeIssues]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these errors were generated in CI, but _tensor_str does seem to exist and is tested

original_options = {k: getattr(options_obj, k) for k in new_options}

torch.set_printoptions(**new_options)
Expand Down
3 changes: 1 addition & 2 deletions extensions/positron-python/python_files/positron/positron_ipykernel/tests/test_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ def test_set_console_width(ui_comm: DummyComm) -> None:
assert np.get_printoptions()["linewidth"] == width
assert pd.get_option("display.width") is None
assert pl.Config.state()["POLARS_TABLE_WIDTH"] == str(width)
if torch is not None: # temporary workaround for Python 3.12
assert torch._tensor_str.PRINT_OPTS.linewidth == width
assert torch._tensor_str.PRINT_OPTS.linewidth == width # type: ignore[reportGeneralTypeIssues]


def test_open_editor(ui_service: UiService, ui_comm: DummyComm) -> None:
Expand Down
Loading