Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem where we were over eager with disposing variables instances #5720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,9 @@ export class PositronVariablesService extends Disposable implements IPositronVar
});

if (existingInstance) {
// Clean up the old session ID mapping
this._positronVariablesInstancesBySessionId.deleteAndDispose(existingInstance.session.sessionId);

// Clean up the old session ID mapping. Don't dispose of the instance because it's
// managed by other parts of the system.
this._positronVariablesInstancesBySessionId.deleteAndLeak(existingInstance.session.sessionId);
// Update the map of Positron variables instances by session ID.
this._positronVariablesInstancesBySessionId.set(
session.sessionId,
Expand Down
Loading