-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improved tags in pull-request #5706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midleman
force-pushed
the
mi/use-pr-action-not-gh-event
branch
3 times, most recently
from
December 12, 2024 00:20
b02079d
to
a592727
Compare
midleman
force-pushed
the
mi/use-pr-action-not-gh-event
branch
from
December 12, 2024 00:22
a592727
to
59632ec
Compare
midleman
changed the title
ci: update test-pull-request to handle tags better
ci: better tags in pull-request
Dec 12, 2024
midleman
changed the title
ci: better tags in pull-request
ci: improved tags in pull-request
Dec 12, 2024
E2E Tests 🚀 ? |
testlabauto
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, re-running the
test-pull-request.yml
workflow failed to detect updated tags in the PR description because it relied on outdated data from the prior GitHub event. This issue has been resolved by using the GitHub API to fetch the latest PR information directly.In addition, a comment is now posted to the PR to confirm the detected tags and provide feedback whenever tags are updated in the PR description.
QA Notes
Confirmed I can re-run jobs after changing tags in PR description and it works as expected.
Feel free to edit/add tags and see the comment update on this PR.
@:data-explorer
Screenshots
Note: The `?` in the comment links to the new section I added in the README. It won't work right now since that readme section is not available in `main` yet.