Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improved tags in pull-request #5706

Merged
merged 22 commits into from
Dec 12, 2024
Merged

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Dec 12, 2024

Summary

Previously, re-running the test-pull-request.yml workflow failed to detect updated tags in the PR description because it relied on outdated data from the prior GitHub event. This issue has been resolved by using the GitHub API to fetch the latest PR information directly.

In addition, a comment is now posted to the PR to confirm the detected tags and provide feedback whenever tags are updated in the PR description.

QA Notes

Confirmed I can re-run jobs after changing tags in PR description and it works as expected.

Feel free to edit/add tags and see the comment update on this PR.
@:data-explorer

Screenshots

Screenshot 2024-12-12 at 7 08 18 AM Note: The `?` in the comment links to the new section I added in the README. It won't work right now since that readme section is not available in `main` yet.

@midleman midleman force-pushed the mi/use-pr-action-not-gh-event branch 3 times, most recently from b02079d to a592727 Compare December 12, 2024 00:20
@midleman midleman force-pushed the mi/use-pr-action-not-gh-event branch from a592727 to 59632ec Compare December 12, 2024 00:22
@midleman midleman changed the title wip ci: update test-pull-request to handle tags better Dec 12, 2024
@midleman midleman marked this pull request as ready for review December 12, 2024 00:50
@midleman midleman changed the title ci: update test-pull-request to handle tags better ci: better tags in pull-request Dec 12, 2024
@midleman midleman changed the title ci: better tags in pull-request ci: improved tags in pull-request Dec 12, 2024
@posit-dev posit-dev deleted a comment from github-actions bot Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical @data-explorer

@posit-dev posit-dev deleted a comment from github-actions bot Dec 12, 2024
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. LGTM!

@midleman midleman merged commit 18b2c3d into main Dec 12, 2024
17 checks passed
@midleman midleman deleted the mi/use-pr-action-not-gh-event branch December 12, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants