Data Explorer: Visually distinguish column names with leading/trailing whitespace or empty string #5653
+54
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
force-pushed
the
feature/de-column-names-leading-whitespace
branch
from
15342be to
8b788ba
Compare
|
E2E Tests 🚀 ? |
wesm
force-pushed
the
feature/de-column-names-leading-whitespace
branch
2 times, most recently
from
8687996 to
a15743a
Compare
wesm
changed the title
wesm
force-pushed
the
feature/de-column-names-leading-whitespace
branch
from
a15743a to
dc14c13
Compare
juliasilge
reviewed
Dec 19, 2024
There was a problem hiding this comment.
This is a big improvement, and so much more clear! 🙌
- The leading/trailing whitespace treatment looks great and consistent for both R and Python.
- The empty string column names for Python look great.
- The empty string column names for R are still rendering like this:
Does there need to be a backend change for the R case? As far as I can tell, the column name is literally just an empty string so I'm not sure why it may be rendering different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address #3084, #3089. Related to #5652, we also cannot distinguish empty strings or strings with leading whitespace in column names both in the data grid headers and the summary panel.
This PR applies the same approach we used for data cells to format column names in the grid headers and the summary pane. The appearance is could potentially be a bit odd because we use non-fixed-width fonts.
e2e: @:data-explorer