test: improve slack notifications #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midleman
force-pushed
the
mi/slack-wflow-status
branch
from
7e23bd3 to
37f82d2
Compare
midleman
force-pushed
the
mi/slack-wflow-status
branch
from
1da785c to
34a364e
Compare
midleman
force-pushed
the
mi/slack-wflow-status
branch
from
fddffcf to
85caea4
Compare
isabelizimm
approved these changes
Dec 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA Notes
This PR introduces the use of a custom GitHub Action to enhance our Slack notifications for test statuses, offering improved context. Currently, all workflows are configured such that notifications are triggered only if any job in the workflow fails.
Some key settings:
notify_on: always, failureinclude_jobs: true, false, on-failureinclude_jobs_time: true, false (handy for hiding on long job names, etc)Confirmed it works with matrix jobs (tested both pass and fail scenarios):
And of course just standard workflows:
