Simplify logic for switching runtimes for a notebook #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstrayer
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little refactor to simplify the logic for switching runtimes for a notebook.
When a user switches from one Positron notebook controller to another, two events are fired: one with
selected === trueand one withselected === false. The order of those events is not guaranteed, so we have to be careful about the order we request to shutdown the previous runtime and start the new one.We previously worked around that by retrying the start request, but it's much simpler to shutdown any existing runtimes in the
selected === truecase.QA Notes
In a notebook, if you change the selected runtime a bunch of times you should be able to execute code in any selected runtime and there should not be any error notifications or console logs.