Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python ci: update macos version to latest #5406

Merged
merged 6 commits into from
Nov 19, 2024
Merged

python ci: update macos version to latest #5406

merged 6 commits into from
Nov 19, 2024

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Nov 18, 2024

from errors noted in #5405 ; macos-12 has been deprecated actions/runner-images#10721

@isabelizimm isabelizimm requested a review from seeM November 18, 2024 18:19
seeM
seeM previously approved these changes Nov 18, 2024
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks!

@seeM
Copy link
Contributor

seeM commented Nov 18, 2024

Ah, seems CI is failing, worth checking upstream to see how they've handled this.

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Nov 18, 2024

Ah, this is coming back to me; upstream does not run macos tests 😬 going to try 13 to see if that works to get us unblocked, but can dig in a little deeper on the failure otherwise

https://github.com/microsoft/vscode-python/blob/5f0279abdf04a640210d6b3f4456fbe364741c08/.github/workflows/pr-check.yml#L146

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Nov 18, 2024

Okay, looks like miniconda used to be shipped in macos on GHA, but as of macos-13 that is no longer the case. actions/runner-images#9748 We'll have to install it on our own in CI

Copy link
Contributor

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm merged commit 12cbdda into main Nov 19, 2024
23 checks passed
@wesm wesm deleted the maint/python-macos-ci branch November 19, 2024 01:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants