Suppress dumping env var information into Python logs #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses: #5320 Sensitive information may be in env vars, we should not output this to the logs by default. Users can always debug their environment using a Terminal.
seeM
previously approved these changes
Nov 13, 2024
extensions/positron-python/src/client/terminals/envCollectionActivation/service.ts
Show resolved
Hide resolved
…ctivation/service.ts Co-authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Pete <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the positron-python extension piece of #5320
Sensitive information may be in env vars, we should not output this to the logs by default. Users can always debug their environment using a Terminal.
QA Notes
After Positron has successfully finished scanning for interpreters and has started a Python interpreter, check the Output tab on the Panel with the
Pythonoutput channel and confirm that a dump of env vars is not present even at the most verbose level.