-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement accumulated improvements to Data Explorer backend protocol, add batch profile requests. In Python implement between, search filter types, prototype search_schema RPC, improve filter API #2585
Conversation
@jmcphers next week could you have a close look through my changes in |
fc7cac2
to
c3e5404
Compare
@isabelizimm or @seeM can you have a look at https://github.com/posit-dev/positron/actions/runs/8510379975/job/23307867670?pr=2585? Doesn't seem related to these changes, a build with 1-year old dependencies (that doesn't include IPython, does it?) EDIT: triaged in main |
Work on search_schema RPC Ported changes from positron-python Add column_index Drafting more APIs per discussions Initial fixes for protocol changes format
c3e5404
to
4eb1eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally reasonable. So nice to see something other than 29% for the null count! 🎉
This PR has a batch of improvements to try to catch up with the UI's current state so we can start hooking up filtering for real:
BetweenFilterParams
,SetMembershipFilterParams
The focus of the next week will be hooking all this up with the recently-built filtering UI and making sure it works properly.