Skip to content

Conversation

dhruvisompura
Copy link
Contributor

@dhruvisompura dhruvisompura commented Aug 29, 2025

Addresses #8529

This PR adds the missing Enter/Space keyboard support for our filter search bars. This change effects the summary panel search bar and the variables pane search bar.

I also removed a couple duplicate search/filter components that are not being used.

Screen.Recording.2025-08-29.at.1.25.03.PM.mov

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@:variables @:data-explorer @:accessibility

@midleman
Copy link
Contributor

Thanks for fixing so fast! Quick question, when the "x" is selected and the user hits Enter to clear the search data, where should the focus go next? I assumed it would be in the search input (it's currently not)... but I'm not sure.

@dhruvisompura
Copy link
Contributor Author

Thanks for fixing so fast! Quick question, when the "x" is selected and the user hits Enter to clear the search data, where should the focus go next? I assumed it would be in the search input (it's currently not)... but I'm not sure.

It should be in the search input! I'll take a look into this. Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants