Make output channel names consistent #5833
Merged
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
|
Love it! Dhruvi and I synced up briefly, while we'd love to maybe someday have nice grouping or other organization of the Positron components (such as consoles together, kernels, or language runtimes, etc), making the naming nice and consistent is a great first pass. |
juliasilge
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
This is working great for me, and the naming updates are a HUGE improvement:
I agree with @jthomasmock that eventually we would like to have more organization here so it is easier for users to find the relevant channels as tracked in #5063, but this PR is a big step in the right direction in terms of clarity and consistency.
juliasilge
requested changes
Dec 19, 2024
juliasilge
approved these changes
Dec 19, 2024
dhruvisompura
deleted the
ds/1707-make-output-channel-names-consistent
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1707
@:output
We've received feedback that the output channel list is confusing and not easy to parse. A lot of the channel names are prefixed with "Positron" which is redundant. The formatting of the names for the language channels is not consistent and adds friction to the UX when scanning the list.
The proposed change here does some tidying 🧹 of the names to improve the UX:
Screenshots