python/ci: adjust CI testing for python 3.8 #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
|
It doesn't look like For now, I'll just pull 3.8 out of every PR's CI (only nightly), and have notes to add in 3.13 |
isabelizimm
changed the title
isabelizimm
commented
Dec 19, 2024
| @@ -738,7 +738,7 @@ def get_display_value( | |||
| "edgeitems": ARRAY_EDGEITEMS, | |||
| "linewidth": print_width, | |||
| } | |||
| options_obj = torch._tensor_str.PRINT_OPTS | |||
| options_obj = torch._tensor_str.PRINT_OPTS # type: ignore[reportGeneralTypeIssues] | |||
There was a problem hiding this comment.
these errors were generated in CI, but _tensor_str does seem to exist and is tested
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #5136
addresses #5137NOTE: due toibis-framework[duckdb]not being available for 3.13, we will not be able to test at this timeThis closely follows the strategy of upstream, which tests on 3.8-3.13.
QA Notes
should pass CI