Skip to content

Commit

Permalink
Data Explorer: Fix data loading regression in DuckDB extension (#5646)
Browse files Browse the repository at this point in the history
Addresses regression introduced in #5644.
  • Loading branch information
wesm authored Dec 6, 2024
1 parent be57de1 commit c7ef34f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion extensions/positron-duckdb/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,10 @@ END`;
const fetchValues = (adapter: (field: Vector<any>, i: number) => ColumnValue) => {
if ('first_index' in spec) {
// There may be fewer rows available than what was requested
const lastIndex = Math.min(spec.last_index, queryResult.numRows - 1);
const lastIndex = Math.min(
spec.last_index,
spec.first_index + queryResult.numRows - 1
);

const columnValues: Array<string | number> = [];
// Value range, we need to extract the actual slice requested
Expand Down

0 comments on commit c7ef34f

Please sign in to comment.