Skip to content

Commit

Permalink
Fix overlapping test result file paths (#4838)
Browse files Browse the repository at this point in the history
The electron and browser tests were using the same results path and thus
only web tests were being report to TestRail.

Also added a run summary block for the web tests.

### QA Notes

Should see full electron run reported to testrail.
  • Loading branch information
testlabauto authored Sep 27, 2024
1 parent b49ae25 commit 8274fe2
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
14 changes: 12 additions & 2 deletions .github/workflows/positron-full-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,21 @@ jobs:
cd ..
rm -rf positron-license
- name: Publish Test Report
- name: Publish Electron Test Report
uses: mikepenz/action-junit-report@v4
if: success() || failure() # always run even if the previous step fails
if: success() || failure()
with:
report_paths: "**/.build/logs/smoke-tests-electron/test-results/*results.xml"
check_name: "Electron Test Results"
token: ${{ secrets.GITHUB_TOKEN }}

- name: Publish Web Test Report
uses: mikepenz/action-junit-report@v4
if: success() || failure()
with:
report_paths: "**/.build/logs/smoke-tests-browser/test-results/*results.xml"
check_name: "Web Test Results"
token: ${{ secrets.GITHUB_TOKEN }}

- name: Set TestRail Run Title
id: set-testrail-run-title
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"smoketest-no-compile": "cd test/smoke && BUILD_ARTIFACTSTAGINGDIRECTORY=../../.build/logs/smoke-tests-electron node test/index.js",
"smoketest-pr": "cd test/smoke && BUILD_ARTIFACTSTAGINGDIRECTORY=../../.build/logs/smoke-tests-electron TEST_FILTER=/#pr/ node test/index.js",
"smoketest-merge-to-main": "cd test/smoke && BUILD_ARTIFACTSTAGINGDIRECTORY=../../.build/logs/smoke-tests-electron node test/index.js",
"smoketest-web": "cd test/smoke && BUILD_ARTIFACTSTAGINGDIRECTORY=../../.build/logs/smoke-tests-electron node test/index.js --web",
"smoketest-web": "cd test/smoke && BUILD_ARTIFACTSTAGINGDIRECTORY=../../.build/logs/smoke-tests-browser node test/index.js --web",
"download-builtin-extensions": "node build/lib/builtInExtensions.js",
"download-builtin-extensions-cg": "node build/lib/builtInExtensionsCG.js",
"download-quarto": "node build/lib/quarto.js",
Expand Down

0 comments on commit 8274fe2

Please sign in to comment.