Skip to content

Commit

Permalink
disable extension validation in Positron
Browse files Browse the repository at this point in the history
  • Loading branch information
jmcphers committed Dec 17, 2024
1 parent 74611ab commit 71b8428
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,13 @@ export class ExtensionManagementService extends AbstractExtensionManagementServi
const value = this.configurationService.getValue('extensions.verifySignature');
verifySignature = isBoolean(value) ? value : true;
}

// --- Start Positron ---
// Disable signature verification for Positron; we don't ship the
// `vsce-sign` tool used to validate signatues.
verifySignature = false;
// --- End Positron ---

const { location, verificationStatus } = await this.extensionsDownloader.download(extension, operation, verifySignature, clientTargetPlatform);

if (verificationStatus !== ExtensionSignatureVerificationCode.Success && verifySignature && this.environmentService.isBuilt && !isLinux) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,11 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
description: localize('extensions.verifySignature', "When enabled, extensions are verified to be signed before getting installed."),
default: true,
scope: ConfigurationScope.APPLICATION,
included: isNative && !isLinux
// --- Start Positron ---
// Do not include this setting in Positron; it is not
// supported.
included: isNative && !isLinux && false
// --- End Positron ---
}
}
});
Expand Down

0 comments on commit 71b8428

Please sign in to comment.