-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove python extension override of PATH variable (#5354)
Related to #4511 the Python extension is using a newer version of VSCode, with a `GlobalEnvironmentVariableCollection` which overwrites other extension's contributions to environment variables, such as PATH. This moves to using `EnvironmentVariableCollection`, which will only touch its extension contributions. From what I understand, the original change was made to be able to set multiple folder level scopes in a workspace, eg, set different interpreters for different folders inside a workspace: microsoft/vscode-python#20492 (comment) and microsoft/vscode#171173 Positron operates (or at least the interpreter dropdown UI shows) 1 interpreter per workspace, so I don’t think the scoping stuff applies to us. ### QA Notes - make sure Quarto is in your local `positron` directory. AFAICT this does not automatically populate on `yarn` runs, so you might have to put it there manually. (At build time, it is at `~/Applications/Positron.app/Contents/Resources/app/quarto/bin`, which is being properly identified by the Quarto extension 👍) - delete other local Quarto installations (likely by running `rm -fr ~/Applications/quarto`) - open up Positron - run `quarto --version` in terminal, should not give any errors --------- Signed-off-by: Isabel Zimmerman <[email protected]>
- Loading branch information
1 parent
e3a1ef1
commit 64e113a
Showing
2 changed files
with
42 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters