Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ulimit when re-creating container #75

Closed
wants to merge 4 commits into from

Conversation

deviantony
Copy link
Member

@deviantony deviantony commented Oct 17, 2023

This PR sets the ulimit associated to a container to null when re-creating a container instead of inheriting it from the previous container configuration.

This should solve the issue that happens when running k2d under Podman and creating services (that re-creates container under the hood).

As setting ulimits is not supported by Kubernetes natively this should not be a breaking change.

@deviantony
Copy link
Member Author

Removing the ulimit leads to another error:

ERROR	controller/controller.go:204	unable to update container	{"error": "unable to create container: Error response from daemon: container create: running container create option: names must match [a-zA-Z0-9][a-zA-Z0-9_.-]*: invalid argument", "request_id": "fbf0acd6-41bb-48ba-8254-7cf7bd7a5a65"}

I believe there is something wrong with inheriting the configuration from a previous container using Podman.

@deviantony
Copy link
Member Author

Closed as this might not be required, the issue is not present on a "standard" deployment of Podman: #68 (comment)

@deviantony deviantony closed this Oct 19, 2023
@deviantony deviantony deleted the fix68-podman-services branch October 19, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant