Remove unsafe type assertions from component merging #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mergeDeeplyfunction insrc/components/merge.tsused type assertions to coerce union types, triggering 6no-unsafe-type-assertionwarnings.Changes:
mergeDeeplywith dedicated type-safe merge functions per component typemergeBlockComponent,mergeListComponent,mergeListItemComponenthandle union types (function | object) with proper type guardsmergeMarksComponent,mergeTypesComponenthandle record types without assertionsBefore:
After:
Each merge function's return type is explicitly typed, allowing TypeScript to verify type safety without assertions.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.