fix: offset reorder index

poppingmoon · Oct 26, 2024 · 5c5db5f · 5c5db5f
1 parent 15e19dc
commit 5c5db5f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/lib/view/page/settings/accounts_page.dart b/lib/view/page/settings/accounts_page.dart
@@ -1,3 +1,4 @@
+import 'dart:math';
 import 'dart:ui';
 
 import 'package:flutter/material.dart';
@@ -58,9 +59,11 @@ class AccountsPage extends HookConsumerWidget {
                 }
               },
               itemCount: accounts.length + 2,
-              onReorder: (oldIndex, newIndex) => ref
-                  .read(accountsNotifierProvider.notifier)
-                  .reorder(oldIndex, newIndex),
+              onReorder: (oldIndex, newIndex) =>
+                  ref.read(accountsNotifierProvider.notifier).reorder(
+                        max(0, oldIndex - 1),
+                        min(newIndex - 1, accounts.length),
+                      ),
               proxyDecorator: (child, _, animation) => AnimatedBuilder(
                 animation: animation,
                 builder: (context, child) {

diff --git a/lib/view/page/settings/tabs_page.dart b/lib/view/page/settings/tabs_page.dart
@@ -64,9 +64,11 @@ class TabsPage extends HookConsumerWidget {
                 }
               },
               itemCount: tabs.length + 2,
-              onReorder: (oldIndex, newIndex) => ref
-                  .read(timelineTabsNotifierProvider.notifier)
-                  .reorder(oldIndex, min(newIndex, tabs.length)),
+              onReorder: (oldIndex, newIndex) =>
+                  ref.read(timelineTabsNotifierProvider.notifier).reorder(
+                        max(0, oldIndex - 1),
+                        min(newIndex - 1, tabs.length),
+                      ),
               proxyDecorator: (child, _, animation) => AnimatedBuilder(
                 animation: animation,
                 builder: (context, child) {