chore: Cookieのsecure属性を開発時のみ付ける
#823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tufusa
requested review from
laminne,
speak-mentaiko,
kiharu3112 and
Suzune2741
Deploying kcmsx with
|
| Latest commit: |
81967e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c40bf43.kcmsx.pages.dev |
| Branch Preview URL: | https://chore-817-cookie-secure-only.kcmsx.pages.dev |
laminne
reviewed
Dec 16, 2024
Comment on lines
+15
to
+17
| await fetch(`${import.meta.env.VITE_API_URL}/logout`).catch( | ||
| () => undefined | ||
| ); |
There was a problem hiding this comment.
[optional] 非自明な気がするのでコメントなりPRのdiscriptionに書くなりしてほしいかも
There was a problem hiding this comment.
どの辺が非自明なのかうまく汲み取れなかったので教えてほしいです(.catch(() => undefined)自体は他の箇所でも使っていますが、これですか？)
There was a problem hiding this comment.
(.catch(() => undefined)自体は他の箇所でも使っていますが、これですか？)
多分これエラーを握り潰してるんだろうけど、できればToDoコメント or できない理由を書いておいてほしいなと思った
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #817