Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add AutoGraphicsPower #386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

curiousercreative
Copy link
Contributor

@curiousercreative curiousercreative commented Feb 6, 2023

Fixes #280
Obsoletes #319

@curiousercreative curiousercreative marked this pull request as ready for review February 6, 2023 17:08
@jacobgkau jacobgkau force-pushed the auto-graphics-power branch from 0e4dcb4 to 041c557 Compare May 12, 2023 15:24
@jackpot51 jackpot51 requested a review from a team February 21, 2024 04:58
@gabriele2000
Copy link

Any news on this?

@jackpot51
Copy link
Member

@pop-os/quality-assurance can we get a review?

@leviport
Copy link
Member

Hmm, CI says it built it, but I can't tell what branch it's on for me to test it... I think CI is confused?

@gabriele2000
Copy link

gabriele2000 commented Oct 25, 2024

Hmm, CI says it built it, but I can't tell what branch it's on for me to test it... I think CI is confused?

Isn't the branch curiousercreative:auto-graphics-power?

EDIT: Indeed, it's impossible to find, that's new
@curiousercreative maybe you could help, since you created it?
Maybe synch it again with master?

EDIT 2: I should just go to bed... it occurred to me that it's a one-liner change, no need to do some crazy stuff here

@leviport
Copy link
Member

Our CI doesn't build other peoples' branches, only those on our repos. We manually push branches like this to our repos to let CI build them so we can test them, and this one says it built, but I can't find where it built. If I try to push to a fresh branch, there's some messy rebasing that needs to be done. Syncing up with current master probably needs to be done anyway, so that would be best. I will begin testing once it's all synced up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on system76-power graphics power auto
5 participants