fix: "Tile Windows" toggle causing recursion when using shortcut

[epetousis]

Fixes #1733, it was an infinite recursion issue that was caused by updating the state for the "Tile Windows" toggle in the indicator popup.

I fixed this by calling the appropriate auto_tile_* method inside the connect callback for the toggle. If this isn't the preferred way to go about it, then I'm happy to change it.

Works on my machine, even if I press and hold the toggle-tiling shortcut key combination.

[jaxwilko]

Tested and fixes the issue on Debian trixie/sid Gnome 47.2 👍

[manavchaudhary1]

Seems to be bugs on Fedora 41 Gnome 47.2
https://imgur.com/a/5SyFXDB
Opens another instance.

[jaxwilko]

Running make local-install calls restart-shell which can be found here:

shell/Makefile

Line 70 in e25621e

restart-shell:

Could it be causing the odd behaviour for you?

On Nvidia my desktop always crashes if I run make local-install from within the DE, so I switch to a different TTY (i.e. CTRL + ALT + 6) then run the command in the tty without a DE. Switching back to Gnome after seems to work fine after doing this.

[manavchaudhary1]

Now it's working after installing from tty3 and rebooting.

[manavchaudhary1]

Ctrl + Enter not coloring window blue , which causes confusion.
Problem specific to this pr working fine in main branch.

[epetousis]

Ctrl + Enter not coloring window blue , which causes confusion.

This sounds like you have my main branch checked out, which is where I'm tinkering with the extension and aiming to implement moving windows without having to hit Ctrl + Enter. Make sure you have the commit epetousis/pop-shell@af83e5e checked out.

[jacobgkau]

Just to keep this straight in case it's important later, the bug in question affects GNOME 47 but not GNOME 46 and below. Ubuntu Noble (24.04) comes with GNOME 46, and we don't have an Oracular branch yet. However, this should be fine, because the fix doesn't seem to cause any regressions on GNOME 46. Toggling the state on and off with both the top-right icon and the keyboard shortcut (and a combination of the two) works normally with this branch on Pop!_OS 24.04 Alpha, as it did before.

On GNOME 47 (testing with EndeavourOS), I was able to recreate the issue before this fix (by simply toggling tiling off with the keyboard shortcut and observing a freeze), and am no longer seeing it occur after the fix.

This is not merging into a stable Pop!_OS branch and does not affect the currently supported 22.04 session.

Thank you for digging into this and contributing the fix!

[dagimg-dot]

Tested on Fedora 41 Gnome 47.2 and the issue is fixed. Thank you all!